-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the debounce extension in order to update to the last action pa… #4294
Conversation
Thanks matheus-inacio for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
UnitTests/UnitTests.UWP/Extensions/Test_DispatcherQueueTimerExtensions.cs
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.UWP/Extensions/Test_DispatcherQueueTimerExtensions.cs
Outdated
Show resolved
Hide resolved
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #4293
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The debounce extension was incorrectly updating the action in the ConcurrentList.
According to documentation the value passed in the
updateValueFactory
function, of theAddOrUpdate
method, is the current value in the dictionary.https://docs.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.addorupdate?view=net-5.0
Therefore the current behavior is maintaining the old action and not updating with the new passed action.
What is the new behavior?
Changed so that the action in the
_ debounceInstances
Dictionary is updated with the latest version.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
PS: The debuonce extension is referenced in the
CanvasPathGeometryPage
class (although this changes does not seem to break it).