Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MVVM Toolkit LINQ expression issues on .NET Framework #4282

Conversation

Sergio0694
Copy link
Member

Fixes #4272

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

There are a couple of scenarios currently where the MVVM Toolkit crashes on .NET Framework:

  • LINQ expression fallback path for ObservableValidator.ValidateAllProperties on a model with no validatable properties
  • LINQ expression fallback path for IMessengerExtensions.RegisterAll on a recipient with no declared handlers

This is due to Expression.Block throwing when receiving an empty collection as input on .NET Framework.
It works fine from .NET Core 2.1 and onwards.

What is the new behavior?

Added an explicit check and short path to skip the LINQ expression calls entirely if no targets are detected.
Both scenarios work correctly now.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior .NET Components which are .NET based (non UWP specific) mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package hotfix 🌶 labels Sep 28, 2021
@Sergio0694 Sergio0694 added this to the 7.1.1 milestone Sep 28, 2021
@ghost
Copy link

ghost commented Sep 28, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio September 28, 2021 09:20
Also fixed some build warnings in the unit test project
@michael-hawker michael-hawker merged commit fc5287e into CommunityToolkit:main Oct 6, 2021
@Sergio0694 Sergio0694 deleted the bugfix/validator-validateall-netfx branch October 6, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package .NET Components which are .NET based (non UWP specific) priority 🚩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]ObservableValidator.ValidateAllProperties() throws exception when no Validation rules exists.
3 participants