Fix MVVM Toolkit LINQ expression issues on .NET Framework #4282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4272
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There are a couple of scenarios currently where the MVVM Toolkit crashes on .NET Framework:
ObservableValidator.ValidateAllProperties
on a model with no validatable propertiesIMessengerExtensions.RegisterAll
on a recipient with no declared handlersThis is due to
Expression.Block
throwing when receiving an empty collection as input on .NET Framework.It works fine from .NET Core 2.1 and onwards.
What is the new behavior?
Added an explicit check and short path to skip the LINQ expression calls entirely if no targets are detected.
Both scenarios work correctly now.
PR Checklist
Please check if your PR fulfills the following requirements: