Fixed culture sensitivity when parsing AspectRatio components #4253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4252
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
AspectRatio.ConvertToAspectRatio(string)
method used for parsing is usingConvert.ToDouble
, which by default uses the current culture for parsing. This causes a crash when trying to parse a number using'.'
as decimal separator on cultures that instead use','
as decimal separator (eg. French, Italian). Furthermore, the parsing behavior is not consistent with eg. the variousVector2/3/4
andQuaternion
parsing APIs in theStringExtensions
class inMicrosoft.Toolkit.Uwp.UI
.What is the new behavior?
Updated the parsing logic in
AspectRatio.ConvertToAspectRatio(string)
to be consistent with other parsing APIs.The parsing is now done using
CultureInfo.InvariantCulture
, which fixes the crash reported in the linked issue.PR Checklist
Please check if your PR fulfills the following requirements: