Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various 7.1 Clean-up Fixes #4251

Merged
4 commits merged into from
Sep 16, 2021

Conversation

michael-hawker
Copy link
Member

Fixes #4210 and Fixes #4158

Cleans up sample for #4248 (though underlying issue remains to be figured out later).

Fixes a sample and cleans-up a few items we missed in our nuget packages. Just need to validate output from CI, but should be fairly straight-forward.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes
  • Sample app changes

What is the current behavior?

TTB Sample was binding to the internal collection instead of showing binding to a developer provided collection.

Some new features were missing from the NuGet package info.

What is the new behavior?

Fixed! 🎉

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Sep 15, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and Rosuavio September 15, 2021 22:00
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ labels Sep 15, 2021
@ghost
Copy link

ghost commented Sep 16, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f18604f into CommunityToolkit:main Sep 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New 7.1 Controls missing from package descriptions Add ThirdPartyNotice file to packages
3 participants