Upgraded Dismiss button to be legible at 225% text display setting #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
accessibility ♿
bug 🐛
|
Opened a similar issue for the neighboring OK & Cancel buttons #4250.
|
1 task
vgromfeld
reviewed
Sep 16, 2021
| Style="{StaticResource DismissTextBlockButtonStyle}"> | ||
| <Button.RenderTransform> | ||
| <TranslateTransform x:Name="DismissButtonTransform" X="25" Y="-5"/> | ||
| <TranslateTransform x:Name="DismissButtonTransform" X="20" Y="2"/> |
There was a problem hiding this comment.
You are using Y="1" in the .bind. I guess we should have the same value in the two files ?
There was a problem hiding this comment.
@XAML-Knight any reason for this?
There was a problem hiding this comment.
I went with what looked good, visually. Would be nice to have a consistent layout, even though the difference is only 1 pixel between the two button transforms.
2 tasks
michael-hawker
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3467
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The 'X' inside the Dismiss button, becomes off-center and generally unreadable when user sets Windows text display to 225%
What is the new behavior?
The 'X' inside the Dismiss button is legible at Windows text display setting of 225%
PR Checklist
Please check if your PR fulfills the following requirements:
Other information