Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DispatcherQueue dispatching for high contrast theme change #4243

Merged

Conversation

Sergio0694
Copy link
Member

Fixes #3253

Applying changes discussed in #3253 (comment).

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Changes to the high contrast theme are propagated on the original synchronization context.

What is the new behavior?

The event handler now dispatches on the current dispatcher queue.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior helpers ✋ labels Sep 13, 2021
@Sergio0694 Sergio0694 added this to the 7.1 milestone Sep 13, 2021
@ghost
Copy link

ghost commented Sep 13, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio September 13, 2021 18:31
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good based on @Jasonstein's suggestion. Do any tests need to be updated?

@Sergio0694 Sergio0694 force-pushed the bugfix/themelistener-thread-crash branch from b72390e to 196aaf7 Compare September 14, 2021 20:20
@Sergio0694 Sergio0694 force-pushed the bugfix/themelistener-thread-crash branch from 196aaf7 to aaa9036 Compare September 14, 2021 20:22
@ghost
Copy link

ghost commented Sep 15, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9d9800d into CommunityToolkit:main Sep 15, 2021
@Sergio0694 Sergio0694 deleted the bugfix/themelistener-thread-crash branch September 15, 2021 19:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior helpers ✋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessible_HighContrastChanged threading issue in dev/7.0.0 impl of ThemeListener
3 participants