Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enable MVVM Toolkit source generator unit tests #4198

Merged

Conversation

Sergio0694
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

The unit tests for the MVVM Toolkit source generator are broken and also don't run in the CI.

What is the new behavior?

Fixed the unit tests and enabled them in the CI.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added testing 🏗️ build 🔥 CI/pipeline 🔬 .NET Components which are .NET based (non UWP specific) mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package labels Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio August 27, 2021 14:35
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they're running in the CI ok.

@michael-hawker michael-hawker added this to the 7.1 milestone Aug 27, 2021
@Sergio0694 Sergio0694 merged commit 0ce4553 into CommunityToolkit:main Sep 3, 2021
@Sergio0694 Sergio0694 deleted the testing/mvvm-toolkit-sg branch September 3, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 CI/pipeline 🔬 mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package .NET Components which are .NET based (non UWP specific) testing 🏗️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants