-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Value Coercion to ConstrainedBox #4169
Add Value Coercion to ConstrainedBox #4169
Conversation
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
…thin a parent for completeness.
Alright added all the tests, should be descent coverage for now until we get real-world scenarios of usage. This PR ready to review. |
UnitTests/UnitTests.UWP/UI/Controls/Test_ConstrainedBox.Alignment.cs
Outdated
Show resolved
Hide resolved
…ConstrainedBox.Alignment.cs
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
@chingucoding know you had called out the Value Coercion initially, so let me know if you want to review or not? |
Sure @michael-hawker , I would love to review this in the next few days! |
Fixes #4166 too
Adds Value Coercion to the properties to ensure they're within a valid range.
Also fixes the issue with MultipleX/Y not triggering layout updates.
Debating whether to add more tests to this PR or not still... 🤔
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Can specify any values for properties.
What is the new behavior?
Will reset/bound properties to expected values if out-of-range.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information