Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nullability attributes generation on .NET Standard targets #4168

Conversation

Sergio0694
Copy link
Member

Fixes #4167

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Build error due to unusable attributes when using [INotifyPropertyChanged] on .NET Standard 2.0.

What is the new behavior?

No build errors, attributes are generated as expected when needed.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package labels Aug 9, 2021
@Sergio0694 Sergio0694 added this to the 7.1 milestone Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio August 9, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVVM Source Generator NotNullIfNotNullAttribute and NotNullAttribute missing when using INotifyPropertyChanged
3 participants