-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes DataGrid colors not updating on theme switch #4138
Conversation
Thanks thiago-cs for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Fixes AlternatingRowForeground not being applied when in Light theme.
I submitted only i commit. I am trying to submit the second commit as a second PR but they got merged... Sorry for the mess. |
This reverts commit 53bc957.
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request. |
Fixes #4119
Fixes DataGrid colors not updating on theme switch.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some DataGrid row group header brushes do not update upon theme switching, resulting in a state where rows are in a theme and row group headers are in the opposite theme. This behavior is undesirable.
What is the new behavior?
In this update the related brushes were moved into the ThemeDictionaries.
After these changes, the DataGrid as a whole switches from a theme to another.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Tested in Windows 21H1 only.