Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org rename: windows-toolkit -> CommunityToolkit #4117

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

azchohfi
Copy link
Contributor

Build is failing due to org rename.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Broken build.

What is the new behavior?

The Build builds 🐱‍💻

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes look good, we'll see how the CI does. I think there's still a versioning issue with .NET Core 2.x that may not be resolved here which happened at the same time?

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally for me.

@Rosuavio
Copy link
Contributor

With two approvals, is this supposed to be stuck here?
image

@michael-hawker
Copy link
Member

Yeah, there's still an open issue we have about the release pipeline not firing correctly @RosarioPulella, we have a mail out about it, but it should be unrelated to this issue, so should be good to merge this in.

@michael-hawker michael-hawker merged commit ca7a31b into main Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixNugetFeed branch July 19, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants