Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samples.json CodeUrl #3682

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix samples.json CodeUrl #3682

merged 1 commit into from
Feb 4, 2021

Conversation

Rosuavio
Copy link
Contributor

Step towards #3594

Update the CodeUrls in sample.json
Builds on #3676, if not merged look at that PR first.

PR Type

What kind of change does this PR introduce?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jan 21, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost January 21, 2021 22:33
@michael-hawker
Copy link
Member

@RosarioPulella think you want this based off of dev/split-controls?

@Rosuavio Rosuavio changed the base branch from master to dev/split-controls January 22, 2021 01:40
@michael-hawker michael-hawker merged commit b3babef into CommunityToolkit:dev/split-controls Feb 4, 2021
@Rosuavio Rosuavio deleted the fix-samples-CodeUrl branch February 4, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants