Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileControl: Remove Animations.Expressions usage #3633

Merged
12 commits merged into from
Dec 17, 2020
Merged

TileControl: Remove Animations.Expressions usage #3633

12 commits merged into from
Dec 17, 2020

Conversation

Rosuavio
Copy link
Contributor

Sept towards #3578.

Remove the TileControl's usage of the Animations.Expressions ns and thus the animations package.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

TileControl's uses Animations.Expressions to build expression animation.

What is the new behavior?

TileControl's uses strings to build expression animation.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Sorry, something went wrong.

@ghost
Copy link

ghost commented Dec 16, 2020

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost December 16, 2020 16:01
@michael-hawker michael-hawker added this to the 7.0 milestone Dec 16, 2020
@ghost ghost added the in progress 🚧 label Dec 16, 2020
@ghost ghost modified the milestones: 7.0, 7.1 Dec 16, 2020
Comment on lines 492 to 493
expressionX.SetReferenceParameter("s", scrollProperties);
expressionY.SetReferenceParameter("s", scrollProperties);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use scroll vs. s here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can. My latest commits makes it so that the string is just fed into the API and only ref'ing it from a const in the code, so its either way IMO. Just one char might be more performant since we have a const for it I see nothing wrong with the string being non descriptive.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@Rosuavio Rosuavio marked this pull request as ready for review December 16, 2020 19:05
@Rosuavio Rosuavio changed the title Remove Animations.Expressions usage from TileControl TileControl: Remove Animations.Expressions usage Dec 16, 2020
Rosuavio and others added 2 commits December 16, 2020 15:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>

Unverified

This user has not yet uploaded their public signing key.
@ghost
Copy link

ghost commented Dec 17, 2020

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! nice work 🚀 🚀

@ghost ghost merged commit 4a59111 into CommunityToolkit:master Dec 17, 2020
@Rosuavio Rosuavio deleted the remove-animations-tilecontrol branch December 18, 2020 01:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants