-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TileControl: Remove Animations.Expressions usage #3633
TileControl: Remove Animations.Expressions usage #3633
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
expressionX.SetReferenceParameter("s", scrollProperties); | ||
expressionY.SetReferenceParameter("s", scrollProperties); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use scroll
vs. s
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can. My latest commits makes it so that the string is just fed into the API and only ref'ing it from a const in the code, so its either way IMO. Just one char might be more performant since we have a const for it I see nothing wrong with the string being non descriptive.
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! nice work 🚀 🚀
Sept towards #3578.
Remove the
TileControl
's usage of theAnimations.Expressions
ns and thus the animations package.PR Type
What kind of change does this PR introduce?
What is the current behavior?
TileControl
's usesAnimations.Expressions
to build expression animation.What is the new behavior?
TileControl
's uses strings to build expression animation.PR Checklist
Please check if your PR fulfills the following requirements:
Other information