Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbitview remove animation expressions #3627

Merged
4 commits merged into from
Dec 15, 2020
Merged

Orbitview remove animation expressions #3627

4 commits merged into from
Dec 15, 2020

Conversation

Rosuavio
Copy link
Contributor

Sept towards #3578.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

OrbitView uses the Toolkit Animation.Expressions API.

What is the new behavior?

OrbitView uses ExpressionAnimation

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Dec 14, 2020

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't notice any differences in behaviors comparing the published sample app and this branch. Thanks @RosarioPulella! 🎉🎉🎉

@ghost
Copy link

ghost commented Dec 15, 2020

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost added the in progress 🚧 label Dec 15, 2020
@ghost ghost added this to the 7.0 milestone Dec 15, 2020
@michael-hawker
Copy link
Member

@Kyaa-dost want to take a quick look to validate this as well?

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Ready to 🚀 🚀

@ghost ghost merged commit a20e824 into CommunityToolkit:master Dec 15, 2020
@Rosuavio Rosuavio deleted the orbitview-remove-animation-expressions branch December 16, 2020 04:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants