-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbitview remove animation expressions #3627
Orbitview remove animation expressions #3627
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I didn't notice any differences in behaviors comparing the published sample app and this branch. Thanks @RosarioPulella! 🎉🎉🎉
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@Kyaa-dost want to take a quick look to validate this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Ready to 🚀 🚀
Sept towards #3578.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
OrbitView uses the Toolkit Animation.Expressions API.
What is the new behavior?
OrbitView uses ExpressionAnimation
PR Checklist
Please check if your PR fulfills the following requirements:
Other information