Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Notifications min version to 10240 #3582

Merged
2 commits merged into from
Dec 10, 2020
Merged

Conversation

andrewleader
Copy link
Contributor

@andrewleader andrewleader commented Nov 25, 2020

Partially addresses #3581 issue 2

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Min version of UWP package in master incorrectly got bumped to 17763

image

What is the new behavior?

Min version of UWP package is 10240. Had to make sure the DefaultTargetMinVersion and TargetMinVersion properties were set in the Notifications project (so the overall default of 17763 didn't get used).

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Nov 25, 2020

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@andrewleader
Copy link
Contributor Author

Tested CI-generated NuGet, it worked! Ready to merge

@michael-hawker michael-hawker added this to the 7.0 milestone Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ec93987 into master Dec 10, 2020
@ghost ghost deleted the aleader/notifications-10240 branch December 10, 2020 19:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants