Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIElement.ClipToBounds property #3193

Merged
merged 12 commits into from
Apr 1, 2020

Conversation

vgromfeld
Copy link
Contributor

@vgromfeld vgromfeld commented Mar 25, 2020

This PR is a continuation of @Sergio0694 work done here: #3111

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

A XAML attached property that uses a composition InsetClip to clip the rendering coming from inside a given UIElement. All additional info can be found in the linked issue (#3108).

PR Checklist

Please check if your PR fulfills the following requirements:

@ghost
Copy link

ghost commented Mar 25, 2020

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost Mar 25, 2020
@Sergio0694 Sergio0694 mentioned this pull request Mar 25, 2020
7 tasks
@michael-hawker
Copy link
Member

Thanks @vgromfeld and @Sergio0694! Really cool to see this collaboration here. 🦙❤

It sounds like this PR is ready for review? I'll try and take a look later today.

@Sergio0694
Copy link
Member

@michael-hawker Should be alright, it has both the actual property and the sample that @vgromfeld added. I don't think unit tests are doable for this specific property, so unless I'm missing something it should be good for review, yeah 😊

@vgromfeld
Copy link
Contributor Author

I've created a documentation PR here: MicrosoftDocs/WindowsCommunityToolkitDocs#308. So yes, we should have everything we need 😀

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small tweaks, but works great, thanks!

@ghost
Copy link

ghost commented Apr 1, 2020

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

@michael-hawker michael-hawker merged commit a4bc01a into CommunityToolkit:master Apr 1, 2020
@michael-hawker michael-hawker mentioned this pull request Apr 1, 2020
36 tasks
@vgromfeld vgromfeld deleted the clipToBounds branch April 2, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants