-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIElement.ClipToBounds property #3193
UIElement.ClipToBounds property #3193
Conversation
Merge Sergio0694 code in my own branch
Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Thanks @vgromfeld and @Sergio0694! Really cool to see this collaboration here. 🦙❤ It sounds like this PR is ready for review? I'll try and take a look later today. |
@michael-hawker Should be alright, it has both the actual property and the sample that @vgromfeld added. I don't think unit tests are doable for this specific property, so unless I'm missing something it should be good for review, yeah 😊 |
I've created a documentation PR here: MicrosoftDocs/WindowsCommunityToolkitDocs#308. So yes, we should have everything we need 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small tweaks, but works great, thanks!
Microsoft.Toolkit.Uwp.UI/Extensions/UIElement/UIElementExtensions.cs
Outdated
Show resolved
Hide resolved
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
This PR is a continuation of @Sergio0694 work done here: #3111
PR Type
What kind of change does this PR introduce?
What is the new behavior?
A XAML attached property that uses a composition
InsetClip
to clip the rendering coming from inside a givenUIElement
. All additional info can be found in the linked issue (#3108).PR Checklist
Please check if your PR fulfills the following requirements:
ClipToBounds
property MicrosoftDocs/WindowsCommunityToolkitDocs#308