Change SystemInformation from static to regular class

[vgromfeld]

This PR is a first step to address #3145.
It reduces the toolkit impact on a blank application by ~3.5 MB (x86, release)

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

SystemInformation is a static class. It contains a static LocalObjectStorageHelper instance.
This static "root" prevents the .Net Native compiler from removing this code from the generated code when not used. LocalObjectStorageHelper is pulling JSON.Net which has a big impact on the generated code size.

What is the new behavior?

SystemInformation has been changed to a regular class. It will be the responsibility of the user to use it as a singleton if needed. This approach allows us to reduce the toolkit impact on the applications when SystemInformation is not used.

This is a breaking change.

	before	after
app.dll	7,949	4,488

Size in Kb, x86 release build, no compilation directive

PR Checklist

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample)
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

The test code. The zip contains two builds of the library (before/after) the proposed change and two blank apps with a dependency on the library but not consuming anything from it.
TestApp.zip

[ghost]

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[azchohfi]

This is GREAT! Thanks!

[michael-hawker]

Think we may just want to go the full path of providing the Singleton pattern ourselves no?

Also, we should make sure this is based off the dev/7.0.0 branch as it'd be a breaking change.

[ghost]

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

[azchohfi]

We need to merge master on 7.0.

[skendrot]

Why are radial gauge changes part of this PR?

[michael-hawker]

@skendrot apparently our 7.0 branch is out of date, so I'm going to investigate this and hopefully once we update, this gets cleaned-up again.

[michael-hawker]

Alright, I updated the 7.0 branch, but I think there's still another change bleeding through? @azchohfi I'm not seeing the option on GitHub showing the PR branch is out of date and need to update again from the dev/7.0.0 branch? Maybe @vgromfeld needs to reset this manually?

[skendrot]

Everything looks good except for the merge issues

[vgromfeld]

@michael-hawker I will do a manual rebase on 7.0 branch to keep only my commits.

Edit: Done

[skendrot]

Looks good. Has documentation been updated?

[azchohfi]

Loved it. Does this still reduces the toolkit impact on a blank application by ~3.5 MB (x86, release)?

[vgromfeld]

Loved it. Does this still reduces the toolkit impact on a blank application by ~3.5 MB (x86, release)?

@azchohfi Yes. The impact is the same.

[vgromfeld]

Looks good. Has documentation been updated?

@skendrot I've created Update SystemInformation documentation in the doc repository.

@michael-hawker I'm not seeing any dev/7 branch in the documentation repository. Should we create one ?

[michael-hawker]

@vgromfeld thanks! I've created a new doc branch, commented on that PR. I need to investigate the doc build failing still though.

[michael-hawker]

Thanks @vgromfeld for this! Let us know if you find any other similar optimizations we can do in other places too!