-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RadialGauge default template value formatting #3153
Conversation
Thanks jeromelaban for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
You should also update the code behind to force a refresh of In the actual implementation, the formatting is refreshed only when |
@jeromelaban did you want to make the fix suggested by @vgromfeld as well? |
This update fixes the `RadialGauge` value text formatting that was overridden by a template binding on the `Value` property. Here's the appropriate text update location: https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ef6527227539362125a0617d9b9821b2c009e11e/Microsoft.Toolkit.Uwp.UI.Controls/RadialGauge/RadialGauge.cs#L537
@michael-hawker yes, just got some time to finish it and update the sample to test it as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this @jeromelaban! 🦙❤
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Changing the
RadialGauge.ValueStringFormat
does not have an effect on the displayed value.What is the new behavior?
This update fixes the
RadialGauge
value text formatting that was overridden by a template binding on theValue
property.Here's the appropriate text update location:
https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ef6527227539362125a0617d9b9821b2c009e11e/Microsoft.Toolkit.Uwp.UI.Controls/RadialGauge/RadialGauge.cs#L537
PR Checklist
Please check if your PR fulfills the following requirements:
Other information