Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scrolled DataGrid not displaying cells from last columns when resized #5011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed scrolled DataGrid not displaying cells from last columns when resized #5011

wants to merge 1 commit into from

Conversation

Xiaoy312
Copy link

Fixes #5010

datagrid cell mia on resize

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

In certain situation, when the data-grid resizes from needing a scrollbar to not, certain cells is no longer visible.

What is the new behavior?

Scrolled cells will remain visible after resize.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@Xiaoy312 Xiaoy312 mentioned this pull request Nov 14, 2024
Merged
11 tasks
@mergify mergify bot mentioned this pull request Nov 18, 2024
Merged
11 tasks
@Arkady23
Copy link

Arkady23 commented Nov 25, 2024 •
edited
Loading

I like to use the built-in C:\Windows\Microsoft.NET\Framework64\v4.0.30319. I can create local notifications using Microsoft.Toolkit.Uwp.Notifications.dll or CommunityToolkit.WinUI.Notifications.dll via Assembly.Load(), GetType() and InvokeMember(). But I can't set the lifetime of the notification. I can't get in touch with my notifications in the notification center to delete the notification without activation. There are no examples anywhere. Is it possible to do this? Can you give me an example like this?
For example, you can display a simple notification like this:

Assembly a = Assembly.Load("CommunityToolkit.WinUI.Notifications");
Type b = a.GetType("CommunityToolkit.WinUI.Notifications.ToastContentBuilder");
dynamic o = new dynamic[1];
o[0]=Activator.CreateInstance(b,BindingFlags.Instance|BindingFlags.Public|BindingFlags.CreateInstance|BindingFlags.NonPublic, null, new object[]{}, null);
o[0].Show();

And how to kill it after 1 minute is not known :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Cells no longer visible when the DataGrid is resized, until resize again
2 participants
@Xiaoy312 @Arkady23