Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataGrid): not displaying cells from last columns when resized from scrolled state #224

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Xiaoy312
Copy link

@Xiaoy312 Xiaoy312 commented Nov 14, 2024

for: CommunityToolkit#5010

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

In certain situation, when the data-grid resizes from needing a scrollbar to not, certain cells is no longer visible.

What is the new behavior?

Scrolled cells will remain visible after resize.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

same fix on wct: CommunityToolkit#5011

@jeromelaban jeromelaban merged commit 0216730 into uno Nov 18, 2024
6 checks passed
@jeromelaban jeromelaban deleted the dev/xygu/20241114/datagrid-cell-mia-on-resize branch November 18, 2024 13:49
@jeromelaban
Copy link
Member

@Mergifyio backport unorel/winui/7.1.200

Copy link

mergify bot commented Nov 18, 2024

backport unorel/winui/7.1.200

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Nov 18, 2024
…200/pr-224

fix(DataGrid): not displaying cells from last columns when resized from scrolled state (backport #224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants