Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Optimization of RadialGauge event handlers #4784

Closed
14 tasks
michael-hawker opened this issue Oct 11, 2022 · 0 comments · Fixed by #4787
Closed
14 tasks

Fix/Optimization of RadialGauge event handlers #4784

michael-hawker opened this issue Oct 11, 2022 · 0 comments · Fixed by #4787
Assignees
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️ optimization ☄ Performance or memory usage improvements
Milestone

Comments

@michael-hawker
Copy link
Member

Describe the bug

Follow-on from #4456

  1. Noticed the event handlers are only getting cleaned up in the Unloaded event instead of OnApplyTemplate before new ones are registered.
  2. Since the Keyboard accelerators don't rely on a template piece, we can register in constructor/loaded event.
  3. we can make lambda's static as https://learn.microsoft.com/uwp/api/windows.ui.xaml.input.keyboardacceleratorinvokedeventargs should contain Element to access/set property values.

Regression

No response

Reproducible in sample app?

  • This bug can be reproduced in the sample app.

Steps to reproduce

N/A

Expected behavior

Not duplicate event registration

Screenshots

No response

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Nuget packages

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ optimization ☄ Performance or memory usage improvements labels Oct 11, 2022
@michael-hawker michael-hawker added this to the 7.1.3 milestone Oct 11, 2022
@michael-hawker michael-hawker self-assigned this Oct 11, 2022
michael-hawker added a commit to michael-hawker/UWPCommunityToolkit that referenced this issue Oct 18, 2022
michael-hawker added a commit to michael-hawker/UWPCommunityToolkit that referenced this issue Oct 18, 2022
michael-hawker added a commit to michael-hawker/UWPCommunityToolkit that referenced this issue Oct 18, 2022
@ghost ghost added the In-PR 🚀 label Oct 18, 2022
Repository owner moved this from In Progress to Done in Windows Community Toolkit Oct 18, 2022
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Oct 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️ optimization ☄ Performance or memory usage improvements
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant