Merge branch 'master' of https://github.com/dpaulino/WindowsCommunity…

…Toolkit-1 into feature/control-width-trigger
CommunityToolkit · Aug 15, 2021 · 738b950 · 738b950
2 parents 5a523c9 + 2d74076
commit 738b950
Show file tree

Hide file tree

Showing 43 changed files with 957 additions and 191 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -4,23 +4,26 @@ about: Create a report to help us fix something that isn't working as expected
 title: ''
 labels: "bug :bug:"
 assignees: ''
-
 ---
 
 <!-- 🚨 PLEASE DO NOT SKIP ANY INSTRUCTIONS AND INFORMATION MENTIONED BELOW AS THEY ARE ALL REQUIRED AND ESSENTIAL TO INVESTIGATE THE ISSUE. ISSUES WITH MISSING INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION
 ...
-IF NOT CERTAIN ABOUT THE ISSUE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "QUESTIONS & HELP" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/questions-help] WHERE YOU CAN DISCUSS AND ENAGAGE WITH THE COMMUNITY TO GAIN FURTHER CLAIRITY REGARDING THE ISSUE  🚨 -->
+IF NOT CERTAIN ABOUT THE ISSUE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "QUESTIONS & HELP" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/questions-help] WHERE YOU CAN DISCUSS AND ENGAGE WITH THE COMMUNITY TO GAIN FURTHER CLARITY REGARDING THE ISSUE  🚨 -->
 
 ## Describe the bug
+
 A clear and concise description of what the bug is.
 
 - [ ] Is this bug a regression in the toolkit?  If so, what toolkit version did you last see it work:
 
 ## Steps to Reproduce
 
-- [ ] Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...) <!-- Being able to reproduce the problem in the sample app, really stream-lines the whole process in being able to discover, resolve, and validate bug fixes. -->
+- [ ] Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)
+
+<!-- Being able to reproduce the problem in the sample app, really stream-lines the whole process in being able to discover, resolve, and validate bug fixes. -->
 
 Steps to reproduce the behavior:
+
 1. Given the following environment (Sample App w/ XAML, Project with Isolated setup, etc...)
 2. Go to '...'
 3. Click on '....'
@@ -30,46 +33,52 @@ Steps to reproduce the behavior:
 <!-- Provide as many code-snippets or XAML snippets where appropriate. -->
 
 ## Expected behavior
-A clear and concise description of what you expected to happen.
+
+<!-- A clear and concise description of what you expected to happen. -->
 
 ## Screenshots
-If applicable, add screenshots to help explain your problem.
+
+<!-- If applicable, add screenshots to help explain your problem. -->
 
 ## Environment
-<!-- Check one or more of the following options with "x" -->
-```
-NuGet Package(s):
+
+<!-- Check one or more of the following options with "x" and replace the {build_number} and {minor_version} with the actual values -->
+
+NuGet Package(s): <!-- Which NuGet Packages have you used -->
 
 Package Version(s):
 
 Windows 10 Build Number:
+
 - [ ] Fall Creators Update (16299)
 - [ ] April 2018 Update (17134)
 - [ ] October 2018 Update (17763)
 - [ ] May 2019 Update (18362)
 - [ ] May 2020 Update (19041)
-- [ ] Insider Build (build number: )
+- [ ] Insider Build ({build_number})
 
 App min and target version:
+
 - [ ] Fall Creators Update (16299)
 - [ ] April 2018 Update (17134)
 - [ ] October 2018 Update (17763)
 - [ ] May 2019 Update (18362)
 - [ ] May 2020 Update (19041)
-- [ ] Insider Build (xxxxx)
+- [ ] Insider Build ({build_number})
 
 Device form factor:
+
 - [ ] Desktop
 - [ ] Xbox
 - [ ] Surface Hub
 - [ ] IoT
 
-Visual Studio
-- [ ] 2017 (version: )
-- [ ] 2019 (version: )
-- [ ] 2019 Preview (version: )
+Visual Studio version:
 
-```
+- [ ] 2017 (15.{minor_version})
+- [ ] 2019 (16.{minor_version})
+- [ ] 2022 (17.{minor_version})
 
 ## Additional context
-Add any other context about the problem here.
+
+<!-- Add any other context about the problem here. -->
diff --git a/.github/ISSUE_TEMPLATE/documentation.md b/.github/ISSUE_TEMPLATE/documentation.md
@@ -4,7 +4,6 @@ about: I have a documentation suggestion or question
 title: "[Docs]"
 labels: documentation
 assignees: ''
-
 ---
 
 <!--

diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -4,27 +4,27 @@ about: I have a new idea or improvement for the toolkit
 title: "[Feature]"
 labels: "feature request :mailbox_with_mail:"
 assignees: ''
-
 ---
 
 <!-- 🚨 PLEASE PROVIDE DETAILED INFORMATION AND DO NOT SKIP ANY INSTRUCTIONS AND INFORMATION MENTIONED BELOW AS THEY ARE ALL REQUIRED AND ESSENTIAL TO HELP US UNDERSTAND THE FEATURE.
 ...
-IF NOT CERTAIN ABOUT THE FEATURE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "IDEAS" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/ideas] WHERE YOU CAN DISCUSS AND ENAGAGE WITH THE COMMUNITY TO GAIN FURTHER CLAIRITY REGARDING THE FEATURE 🚨 -->
+IF NOT CERTAIN ABOUT THE FEATURE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "IDEAS" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/ideas] WHERE YOU CAN DISCUSS AND ENGAGE WITH THE COMMUNITY TO GAIN FURTHER CLARITY REGARDING THE FEATURE 🚨 -->
 
 ## Describe the problem this feature would solve
+
 <!-- Please describe or link to any existing issues or discussions.
 A clear and concise description of what the problem is, starting with the user story.
 Provide examples of the restrictions in the current environment that hinders the work your users or you want to perform. What are the ways this new feature will help transform and deliver those results?
 For example, I am currently using the InfiniteCanvas control which lacks the TabbedCommandBar control feature. I am looking to improve user experience therefore i would like to use that in my project to provide ease of accessibility and a user-friendly interface. This new feature will provide quick access to the toolbar, enhance space utilization, etc [...] -->
 
-
 ## Describe the solution
-<!-- A clear and concise description of what you want to happen. Define how do you think it will help the community and adds value to the toolkit? -->
 
+<!-- A clear and concise description of what you want to happen. Define how do you think it will help the community and adds value to the toolkit? -->
 
 ## Describe alternatives you've considered
-<!-- A clear and concise description of any alternative solutions or features you've considered. -->
 
+<!-- A clear and concise description of any alternative solutions or features you've considered. -->
 
 ## Additional context & Screenshots
+
 <!-- Add any other context or screenshots about the feature request here.-->
diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md
@@ -4,7 +4,6 @@ about: I have a question about how to use something in the toolkit.
 title: "[Question]"
 labels: "question :grey_question:"
 assignees: ''
-
 ---
 
 <!--

diff --git a/.github/ISSUE_TEMPLATE/win32_controls.md b/.github/ISSUE_TEMPLATE/win32_controls.md
@@ -4,7 +4,6 @@ about: I have an issue with a Toolkit WPF or WinForms control
 title: "[Win32]"
 labels:
 assignees: ''
-
 ---
 
 <!--

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,17 +1,19 @@
 <!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->
 
-<!-- 👉 It is imperative to resolve ONE ISSUE PER PR and avoid making multiple changes unless the changes interrelate with each other --> 
+<!-- 👉 It is imperative to resolve ONE ISSUE PER PR and avoid making multiple changes unless the changes interrelate with each other -->
 
 <!-- 📝 Please always keep the "☑️ Allow edits by maintainers" button checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork. This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->
 
+## Fixes
 
-## Fixes #
-<!-- Add the relevant issue number after the "#" mentioned above (for ex: "## Fixes #1234") which will automatically close the issue once the PR is merged. -->
+<!-- Add the relevant issue number after the word "Fixes" mentioned above (for ex: "## Fixes #1234") which will automatically close the issue once the PR is merged. -->
 
 <!-- Add a brief overview here of the feature/bug & fix. -->
 
 ## PR Type
+
 What kind of change does this PR introduce?
+
 <!-- Please uncomment one or more options below that apply to this PR. -->
 
 <!-- - Bugfix -->
@@ -23,30 +25,30 @@ What kind of change does this PR introduce?
 <!-- - Sample app changes -->
 <!-- - Other... Please describe: -->
 
-
 ## What is the current behavior?
-<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
 
+<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
 
 ## What is the new behavior?
-<!-- Describe how was this issue resolved or changed? -->
 
+<!-- Describe how was this issue resolved or changed? -->
 
 ## PR Checklist
 
-Please check if your PR fulfills the following requirements:
+Please check if your PR fulfills the following requirements: <!-- and remove the ones that are not applicable to the current PR -->
 
-- [ ] Tested code with current [supported SDKs](../readme.md#supported)
-- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
+- [ ] Tested code with current [supported SDKs](../#supported)
+- [ ] Pull Request has been submitted to the documentation repository [instructions](../blob/main/Contributing.md#docs). Link: <!-- docs PR link -->
 - [ ] Sample in sample app has been added / updated (for bug fixes / features)
-    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets)
+  - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets)
 - [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/CommunityToolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
 - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
-- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
+- [ ] Header has been added to all new source files (run _build/UpdateHeaders.bat_)
 - [ ] Contains **NO** breaking changes
 
 <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
-     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->
-
+Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->
 
 ## Other information
+
+<!-- Please add any other information that might be helpful to reviewers. -->
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
@@ -68,9 +68,9 @@ members of the project's leadership.
 ## Attribution
 
 This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+available at <https://www.contributor-covenant.org/version/1/4/code-of-conduct.html>
 
 [homepage]: https://www.contributor-covenant.org
 
 For answers to common questions about this code of conduct, see
-https://www.contributor-covenant.org/faq
+<https://www.contributor-covenant.org/faq>
diff --git a/Contributing.md b/Contributing.md
@@ -1,39 +1,46 @@
-# Contributing to the Windows Community Toolkit :sparkles::sparkles:
+# ✨ Contributing to the Windows Community Toolkit
 
 Thank you for exhibiting interest in contributing to the Windows Community Toolkit. The team is delighted to welcome you onboard to our exciting and growing project. Any contribution or value added go a long way to enhance the project!
 
 In the next few steps, you will be able to see a glimpse of ways you can contribute to the Windows Community Toolkit.
 
-:rotating_light: **It is highly recommended to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) where you can find complete and detail-oriented content of this page** :rotating_light:
+🚨 **It is highly recommended to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) where you can find complete and detail-oriented content of this page** 🚨
 
-## <a name="question"></a> Questions :grey_question:
-Due to the high volume of incoming issues please keep our GitHub issues for bug reports and feature requests. For general questions, there is a higher chance of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/windows-community-toolkit) where questions should be tagged with the tag windows-community-toolkit.
+## ❔ Questions <a name="question"></a>
+
+Due to the high volume of incoming issues please keep our GitHub issues for bug reports and feature requests. For general questions, there is a higher chance of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/windows-community-toolkit) where questions should be tagged with the tag `windows-community-toolkit`.
 
 For missing documentation related question, please file an issue at [Microsoft Docs](https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/issues/new).
 
-## <a name="bug"></a> Fix a Bug :bug:
-If you find any bug, you can help the community by [submitting an issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=bug+%3Abug%3A&template=bug_report.md&title=). Once the issue is filed, feel free to start working on the PR and submit a PR.
+## 🐛 Fix a Bug <a name="bug"></a>
+
+If you find any bug, you can help the community by [submitting an issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?template=bug_report.md&labels=bug+:bug:&title=[Bug]). Once the issue is filed, feel free to start working on the PR and submit a PR.
+
+## 👌 Good First Issue <a name="issue"></a>
+
+If this is your first time contributing to the Windows Community Toolkit (_WCT_) and do not have advanced level programming experience, we have got you covered 💥 WCT has a list of [good first issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/good%20first%20issue) that can be a great entryway to find and fix any issues that best fit your expertise or technical background.
 
-## <a name="issue"></a>Good First Issue :ok_hand:
-If this is your first time contributing to the Windows Community Toolkit and do not have advanced level programming experience, we have got you covered :boom: WCT has a list of [good first issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/good%20first%20issue%20%3Aok_hand%3A) that can be a great entryway to find and fix any issues that best fit your expertise or technical background.
+## 🙋 Help Wanted <a name="help"></a>
 
-## <a name="help"></a>Help Wanted :raising_hand:
-WCT has a list of issues that are labeled as [help wanted](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/help%20wanted%20%3Araising_hand%3A). The level of complexity in the list can vary but if you have an advanced level of programming experience, feel free to jump in to solve these issues.
+WCT also has a list of issues that are labeled as [help wanted](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/help%20wanted). The level of complexity in the list can vary but if you have an advanced level of programming experience, feel free to jump in to solve these issues.
 
-## <a name="feature"></a>Add New Feature :mailbox_with_mail:
-*	To contribute a new feature, fill out the [Feature Request Template](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=feature+request+%3Amailbox_with_mail%3A&template=feature_request.md&title=%5BFeature%5D) and provide detailed information to express the proposal.
-*	Once the Feature Request is submitted, it will be open for discussion.
-*	If it gets approved by the team, proceed to submit a PR of the proposed Feature.
-*	If the PR contains an error-free code and the reviewer signs off, the PR will be merged.
+## 📬 Add New Feature <a name="feature"></a>
 
-## <a name="docs"></a> Add or Improve Documentation :page_with_curl:
+* To contribute a new feature, fill out the [Feature Request Template](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?template=feature_request.md&labels=feature+request+:mailbox_with_mail:&title=[Feature]) and provide detailed information to express the proposal.
+* Once the Feature Request is submitted, it will be open for discussion.
+* If it gets approved by the team, proceed to submit a PR of the proposed Feature.
+* If the PR contains an error-free code and the reviewer signs off, the PR will be merged.
+
+## 📝 Add or Improve Documentation <a name="docs"></a>
 
 Due to the involvement of multiple steps to add or improve documents; it is required to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) and follow contribution guidelines.
 
-## <a name="pr"></a>Create, Submit or Review Pull Request :rocket:
-Anyone with write access can create a Pull Request by forking the Windows Community Toolkit Repository. Here is how you can [Create a Pull Request from fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). Once you fork the Windows Community Toolkit repo, it is essential to create all changes in the feature branch of your forked repository. If you have the changes in the forked feature branch, you can then create a Pull Request in the main Windows Community Toolkit.
+## 🚀 Create, Submit or Review Pull Request <a name="pr"></a>
+
+Anyone can create a Pull Request by forking the Windows Community Toolkit Repository. Here is how you can [Create a Pull Request from fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). Once you fork the Windows Community Toolkit repo, it is essential to create all changes in the feature branch of your forked repository. If you have the changes in the forked feature branch, you can then create a Pull Request in the main Windows Community Toolkit.
 
 Please visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) for detailed information and steps it requires to Submit or Review Pull Request.
 
-# ThankYou :heart::heart:
-**Thank you so much for contributing to this amazing project. We hope you will continue to add value and find yourself as a highly reliable source to the Windows Community Toolkit**
+## 💙 Thank You
+
+**Thank you so much for contributing to this amazing project. We hope you will continue to add value and find yourself as a highly reliable source to the Windows Community Toolkit.**
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,6 @@ about: I have a documentation suggestion or question @@
     title: "[Docs]"
     labels: documentation
     assignees: ''
     ---
     <!--
@@ Expand Down @@