Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port LayoutTransformControl #83

Merged
merged 17 commits into from
Jul 11, 2023
Merged

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jun 7, 2023

Porting the LayoutTransformControl, addressing: #82

  • Tested on UWP, WASDK and WASM
  • Visual improvements to the sample

@niels9001 niels9001 requested a review from Arlodotexe June 7, 2023 15:31
@niels9001 niels9001 linked an issue Jun 7, 2023 that may be closed by this pull request
@niels9001
Copy link
Collaborator Author

@Arlodotexe Could it be that Uno somehow doesn't include the Media bits? There is a "Uno TODO" comment in their branch: https://github.com/unoplatform/Uno.WindowsCommunityToolkit/blob/833fb61bd684f2796c16168f8047fb477abd4151/CommunityToolkit.WinUI.UI.Controls.Layout/LayoutTransformControl/LayoutTransformControl.cs#LL163C30-L163C30

It builds/run fine locally though..

@jeromelaban
Copy link

jeromelaban commented Jun 16, 2023

@Arlodotexe @niels9001 that's interesting. This particular class is built in Uno's fork, and I suspect that the // Uno todo was related to a type ambiguity with Matrix in very early versions of Uno.

We've made a lot of progress with matrix computation and transforms in general in Uno, so it's likely working fine now (the namespace does not clash anymore).

@michael-hawker
Copy link
Member

Realizing that I'll need this if we want to do the Expander "extension" that I never finished... maybe that has to be a post 8.0 thing... hmmm 🤔

@Arlodotexe Arlodotexe enabled auto-merge (rebase) July 11, 2023 00:45
@Arlodotexe Arlodotexe merged commit 267f09a into main Jul 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/port-layouttransformcontrol branch July 11, 2023 01:19
@jeromelaban
Copy link

@Arlodotexe My validation PR has shown that on Android, Matrix is a publicly accessible type that interferes with the default resolution scope, which means that the Matrix type needs to be fully qualified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port LayoutTransformControl
4 participants