-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting TokenizingTextBox #77
Conversation
@Arlodotexe When copying the |
This reverts commit f982bca.
components/TokenizingTextBox/tests/Test_TokenizingTextBox_AutomationPeer.cs
Show resolved
Hide resolved
components/TokenizingTextBox/src/CommunityToolkit.WinUI.Controls.TokenizingTextBox.csproj
Show resolved
Hide resolved
…ls.TokenizingTextBox.csproj
@Arlodotexe did you see the crash as mentioned above? |
It looks like you are referencing the primitives .csproj directly via the MSBuild property Uno does appear to have an issue though. We should file a ticket to investigate this issue so it can be fixed from Uno's end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't try testing locally yet, but just going through a few things to get up to speed. Did a comparison with Uno fork and didn't notice any big differences. I know originally, I had tested this control on Android for the Graph components, but don't think I had tried WASM at the time.
components/TokenizingTextBox/src/CommunityToolkit.WinUI.Controls.TokenizingTextBox.csproj
Show resolved
Hide resolved
components/TokenizingTextBox/src/TokenizingTextBox.Selection.cs
Outdated
Show resolved
Hide resolved
components/TokenizingTextBox/src/InterspersedObservableCollection.cs
Outdated
Show resolved
Hide resolved
…ion.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
This PR ports the
TokenizingTextBox
to the new repo, addressing: #53Changes:
TokenizingTextBox
to make it inline with WinUI styling:Before:
After:
ItemsPresenter
issue we were having withSettingsExpander
as well?