Porting CameraHelper and CameraPreview #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Arlodotexe Warnings are causing CI to fail. Would you mind having a look? |
Arlodotexe
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports:
CameraPreview@Arlodotexe
ApplicationView.SuspendingandApplicationView.ResumingAPIs are missing - I could imagine that might cause some unexpected behavior switching apps while having the sample open. But overall, the control seems to work :).WebcamCapability to the UWP/WASDK heads within the project. I also enabled it for thetoolingproject - is a separate PR in thetoolingrepo adding this required?