Fixes #513 - AdvancedCollectionView not working with NativeAoT #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith embedded sample.
…which was making for odd namespace collision (less confusing/mixed this way) The last commit was similar to what was needed to fix #514
…le to use x:Bind instead
michael-hawker
added
documentation
michael-hawker
force-pushed
the
llama/acv-fix513
branch
from
c42e4ac to
d5d7f22
Compare
Jay-o-Way
reviewed
Oct 19, 2024
michael-hawker
commented
Oct 21, 2024
Apply suggestions from code review
Arlodotexe
approved these changes
Oct 30, 2024
Arlodotexe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513
Similar fix to #514 along with a bit of extra clean-up to simplify samples.
PR Type
What kind of change does this PR introduce?
Mainly using x:Bind instead of Binding to make sample work with AoT.
What is the current behavior?
Doesn't display information in list.
What is the new behavior?
Information displayed.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Tested in Debug/Release