-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: AdvancedCollection inserts at wrong position when adding to end of source collection #309
Fix: AdvancedCollection inserts at wrong position when adding to end of source collection #309
Conversation
Quickly testing here, There's no exceptions thrown when you Since the intention is to keep the I'll set up a quick minimal repro so we can observe the issue and make sure this fix does what we want. |
The impact of this PR is really minimal, and it fixes an obvious bug. Please review and move forward. |
@Arlodotexe what's the additional work needed here? Can we get this merged or can we get a review comment for what else needs to be done so we can get it done? This is a pretty bad bug as it breaks an important assumption of the AdvancedCollection staying in sync with the original collection. |
Honestly, I already copied the source code into my project, and even refactored it into generic compat |
Care to share the link to your improved version @Lightczx ? |
Me too. But the new controls |
Well, if that's the new model of Microsoft OpenSource projects, then so be it. We just copy the code, fix it an use it... Long live the MIT License. Any of the maintainers care to comment on why Pull Requests submitted, even after thorough explanation, testing and due diligence by the submitter, get stuck at "Review Required" with no feedback? |
We're still putting together the 8.1 update and in addition to features and bug fixes, we've been ironing out various tooling issues that have been cropping up. Adding You can follow along and see where we're at in the current iteration of our project board for 8.x. We just recently closed off some of the larger issues we were having (again, see the .net8 prs [1] [2]), so I plan to start closing off the smaller bugfix PRs now (like this one). Thanks for your patience 🙂 |
Thank you for the update. |
@Poker-sang Good news! I've fleshed out our unit tests and was able to reproduce the issue described. I can confirm that the changes you've made fixes the broken test case, so we're good to close once CI passes 🚀 |
Fixes
closes #307
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
The new item is now added to the end of the collection.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information