Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niels9001/recategorization #211

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Niels9001/recategorization #211

merged 5 commits into from
Sep 1, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Sep 1, 2023 •
edited
Loading

Moving a bunch of categories around and:

  • Removing SettingsPageExample.md and move it to the SettingsExpander page as it was only a sample.
  • Shadows: overview page, and dedicated CardShadow/DropShadow pages.

This requires: CommunityToolkit/Tooling-Windows-Submodule#133

@niels9001 niels9001 requested review from michael-hawker and Arlodotexe and removed request for michael-hawker September 1, 2023 16:14
michael-hawker
michael-hawker reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass at some of the changes, mostly just taking notes for things left for us to maybe do before, doesn't have to be in this PR.

components/Extensions/samples/TextBoxExtensions.md Show resolved Hide resolved
components/Extensions/samples/ShadowAnimations.md Show resolved Hide resolved
components/Extensions/samples/ListViewExtensions.md Show resolved Hide resolved
components/Extensions/samples/AttachedShadows.md Show resolved Hide resolved
@niels9001 niels9001 mentioned this pull request Sep 1, 2023
Merged
michael-hawker
michael-hawker approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go forward!

@michael-hawker michael-hawker merged commit 8ff85e7 into main Sep 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/recategorization branch September 1, 2023 22:00
@michael-hawker michael-hawker mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niels9001 @Arlodotexe @michael-hawker