Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uno.check in dotnet-tools.json to 1.14.0 #201

Closed
wants to merge 2 commits into from

Conversation

michael-hawker
Copy link
Member

Needed to unblock CI, see unoplatform/uno.check#155 (comment)

@michael-hawker
Copy link
Member Author

@Arlodotexe this wants .NET 7.0.400 now, you had pinned to .100 for some reason... why was that?

@Arlodotexe
Copy link
Member

Arlodotexe commented Aug 29, 2023

@Arlodotexe this wants .NET 7.0.400 now, you had pinned to .100 for some reason... why was that?

I was seeing errors related to missing dotnet workloads that were resolved by downgrading. We can try bringing it back to the latest, see if the errors are still there after updating Uno Check.

@jeromelaban
Copy link

Apologies for the issues here... It's generally best to specify a manifest explicitly in CI to pin on a specific version of workloads, but in the case of 1.14.1 that just got release, using an explicit version won't bother you again in the future (without requiring a manifest).

@jeromelaban
Copy link

If you want to use the manifest from 1.13.0 to unblock your build, you can use this one:

--manifest https://raw.githubusercontent.com/unoplatform/uno.check/c3b289d7bb16a2a2df7f7f7f848d76fe1e74036d/manifests/uno.ui.manifest.json

@michael-hawker michael-hawker force-pushed the llama/update-uno-check branch from 461d7d4 to fdceba5 Compare August 29, 2023 20:17
@michael-hawker
Copy link
Member Author

.NET is complaining about the net7.0-maccatalyst TFM now:

C:\Program Files\dotnet\sdk\7.0.400\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(113,5): error NETSDK1139: The target platform identifier maccatalyst was not recognized. [C:\a\Windows\Windows\components\Primitives\samples\Primitives.Samples.csproj::TargetFramework=net7.0-maccatalyst]

So, we'll want to fix that forward or attempt to setup the manifest.

@michael-hawker
Copy link
Member Author

Will close this PR and leave this branch around for now for the future, will open another branch to attempt just rolling back to Uno-check 1.13 and using the default manifest snapshot Jerome provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants