Initial 'Effects' component + AttachedShadowBase/AttachedDropShadow #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
force-pushed
the
port/shadows
branch
from
9b3a338 to
8c00de5
Compare
michael-hawker
force-pushed
the
port/shadows
branch
from
8c00de5 to
f915628
Compare
|
Oops, mis-renamed a file/type in the test, should hopefully be good now. |
Open
Tested on WinAppSDK + UWP (need to compare with UWP branch next though) Removed need for internal DesignTimeHelpers in Extensions (only cares about 16299 and lower which is below our min target) Added basic sample, needs to bring over more detail/doc here Added overall doc from doc repo, though needs editing/updating
…e and Style examples
michael-hawker
force-pushed
the
port/shadows
branch
from
0f6db80 to
3a61eb3
Compare
|
Rebased on latest main |
Arlodotexe
reviewed
Apr 19, 2023
Arlodotexe
approved these changes
Apr 19, 2023
Co-authored-by: Arlo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5
Goal for the 'Effects' package is to hopefully house anything related to Composition and tweaking visuals in a nice package that uses the similar
Effects.*attaching API (we could potentially do this with the Pipeline Brush and Visual Factory stuff in theMediapackage, at least for anything that doesn't use Win2D effects (which is minimal, but still abstractions being here could be good)). We'd have a similarEffects.MediaorMedia.Effectsfor the Win2D dependency with more implementations...This package only supports UWP and WinAppSDK. (We still have the issue in the individual component solution with the WASM head being brought over.) Related to CommunityToolkit/Tooling-Windows-Submodule#5
Ported from WinUI branch, audited against UWP branch. Should be good outside of bringing over more samples and better breaking them out in the docs to explain style usage vs. shared as a resource vs. adding to a naked element.