-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues with the build script in detecting dump files to upload and analyze #174
Conversation
f70cbd3
to
e1d0551
Compare
Was using linux command, but the default Windows shell is PowerShell, so adjusted command, should be good now. Also VS Code kept modifying the config file due to the new dotnet environment they shipped, so made change here so it stops modifying it locally all the time. |
e1d0551
to
84c90e0
Compare
Ok, didn't realize PowerShell would throw an error and stop things inline like that, added |
84c90e0
to
6b597e0
Compare
Added always flag for detecting the dump file. |
6b597e0
to
bc3e6e3
Compare
Still not doing what I expect with the detection... outputting some tests Removed the vs code config stuff, something happened with an infinite loop for me locally suddenly with the new C# extension (conflict between need for msbuild as winappsdk vs. it trying to use dotnet or something...) We'll have to look into that later for #101 |
f842422
to
764a75b
Compare
Think I've got the build stuff sorted now with the auto-dump analysis (though doesn't seem as helpful in these test scenarios without more commands), though adding /Blame to the test runner does provide nicer output of the crash. Tried ignoring a few tests that pop-up in the logs, but really think this is a memory constriction type issue. |
764a75b
to
466411e
Compare
Rebased on top of #173 in order to get preview feed packages so I can check NuGet icon whilst I'm doing builds. |
@Arlodotexe do you want us to merge this into your .NET 7 branch as it should be more stable with the few disabled tests hopefully (or at least better report ones that are still problematic)? |
Hmm, filename change for casing didn't make a difference. The |
466411e
to
c18dc07
Compare
…and analyze dorny/paths-filter only works on detecting changes to git files not untracked files Add Blame to test runner and upload of sequence file
… all examples show lowercase? Also, add PackageIconUrl back as acceptable to have both for backwards compat
… it's just random based on number of tests run...) Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121 Related to investigation, see info in actions/runner-images#7937
See if this helps with `PackageIcon`
c18dc07
to
720fd28
Compare
Alright, rebased back on top of main so we can merge ahead of #173 if needed. |
@michael-hawker Nit: Nuget recommends a 128x128px icon vs. the 256 we use now? But I'll PR and update that so this can go through! |
#170 failed on
main
here: https://github.com/CommunityToolkit/Windows/actions/runs/5828716207/job/15806953245But the dump detection, upload, and auto-analysis didn't run.
I missed that the plugin (dorny/paths-filter) I picked doesn't work on untracked files, only git files. So using GitHub Action output to search for a dump file and use that for analysis.
Will see if this build fails at least once for a test... (the rare time you want something to fail)...
Fixes CommunityToolkit/Tooling-Windows-Submodule#7 in c18dc07