-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Extension Test/Sample Work #15
Conversation
b00da34
to
0407bb8
Compare
Oops, guess I hadn't finished and brought the namespace into the XAML, pushed a fix. Hope that's it. If it all works, then I should spend a bit more time bringing in rest of tests and samples. Should remove the TODO that ignores the thing about docs needing samples. |
I did check the build logs and see that in the tooling module it pulls the extension package from our artifacts feed, but here where we're doing the project reference it doesn't. So, I think we're good on that front! Should mean that we can use this similar setup now for other packages or the sample app if we need to pull in other Toolkit components, we can test things and iterate as needed in the main repo, and then push to packages for the components to consume via the feed in other repos via the tooling module... FYI @Arlodotexe Was just a bigger pain in particular here with how ingrained the extensions were and needing to tease out the namespaces to be unified and get to a place where we were good building. Hopefully anything else we start needing isn't as critical and we can bring to be unified first and build on top of that instead. |
|
0407bb8
to
78a440c
Compare
Some issues with threading, CI should pass now and tests run. |
Let's review and merge this to get everything stable on top of the extensions, and then I can add another PR later as needed to finish samples/tests. |
… helper (test) Add back some of the removed tests to the test project for extensions Adds nuget.config
04d64e3
to
bad05e5
Compare
Setup to add back usage of the Extensions in tests via source package helper (test)
Add back some of the removed tests to the test project for extensions Adds nuget.config
Based on updates to submodule here: CommunityToolkit/Tooling-Windows-Submodule#41
Should probably wait to get the sub-module stuff tested and merged and then update in this PR. Probably want to test this PR with and without the new property to test things E2E, initial test is with property as module pipeline should test without.