Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed codespaces not cloning submodule automatically #146

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

Arlodotexe
Copy link
Member

This PR fixes an issue where codespaces weren't automatically cloning the required submodule when first started up.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) July 15, 2023 16:39
@Arlodotexe Arlodotexe added bug Something isn't working dev loop ➰ low difficulty A small or trivial change that isn't difficult to complete. regression What was working is now broke labels Jul 15, 2023 — with GitHub Codespaces
@Arlodotexe
Copy link
Member Author

Needs #145

@michael-hawker
Copy link
Member

@Arlodotexe once this is good we should be able to test on Codespaces again, eh? Wonder if that'll help diagnose what's wrong in #138... I'm a bit confused by this one.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 18, 2023

The active test run was aborted. Reason: Unable to communicate with test host process.
Terminating app with process ID '6328'.
Results File: D:\a\Windows\Windows\TestResults\WinAppSdk.trx

Test Run Aborted with error System.AggregateException: One or more errors occurred. ---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. ---> System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host
Total tests: Unknown
   at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
     Passed: 270
   --- End of inner exception stack trace ---
    Skipped: 2
   at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
   at System.IO.Stream.ReadByte()
   at System.IO.BinaryReader.ReadByte()
   at System.IO.BinaryReader.Read7BitEncodedInt()
   at System.IO.BinaryReader.ReadString()
   at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.LengthPrefixCommunicationChannel.NotifyDataAvailable()
   at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.TcpClientExtensions.MessageLoopAsync(TcpClient client, ICommunicationChannel channel, Action`1 errorHandler, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---.
 Total time: 39.5070 Seconds
Error: Process completed with exit code 1.

Hmmm, WinAppSDK failing because of platform issues?

@Arlodotexe Arlodotexe merged commit 15ce805 into main Jul 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/codespaces/submodule-not-auto-cloning branch July 19, 2023 00:01
@michael-hawker
Copy link
Member

@Arlodotexe been seeing that issue a lot on both pipelines, not sure what's going on. Every now and then restarting doesn't work. Assuming something updated on the environment again? No idea why it's failing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev loop ➰ low difficulty A small or trivial change that isn't difficult to complete. regression What was working is now broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants