Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package clean-up for Extensions, Animations, and Behaviors #121

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Jul 10, 2023

Notice we've had a splintering of some packages and some things with very few things in them.

Going to clean-up this issue and merge things back together.

  1. Move Effects shadow stuff back into Extensions (originally had more plans here, but for now doesn't make sense to separate out just Shadows, even if they're the main thing not supported by Uno)
  2. Make Animations target Uno - we can make the default layer on Uno the XAML layer for the XAML interop helpers
  3. Merge Behavior.Animations back into Behaviors - Not much there, and we see most folks that use Behaviors are also using the Animations package already anyway.

Separate PRs:

May effect #113

Started with 1 as draft, working on 2 next

@michael-hawker michael-hawker added the enhancement New feature or request label Jul 10, 2023
@michael-hawker
Copy link
Member Author

Yay! Clean build for step 1!

image

Think have Animations package working for Uno (and defaulting to XAML layer); however, we have like no samples for the Animations currently, so hard to test.

Adding multi-target to Behaviors.Animations quick to see if that sample works on WASM, if so, then we have success! And then will do third step of merging the Behaviors package together.

@michael-hawker michael-hawker force-pushed the llama/package_collapsing branch from 98dd1a4 to 5891f98 Compare July 10, 2023 23:43
@michael-hawker michael-hawker marked this pull request as ready for review July 10, 2023 23:44
@michael-hawker
Copy link
Member Author

michael-hawker commented Jul 10, 2023

Have all the refactors/code changes done now. Everything should target Uno. Tested building for all three platforms, seems fine.

Haven't been able to see the existing samples load in WASM though still, so not sure what's going on there. I don't see any Uno errors in the output. Some other Behaviors seem to work alright.

Theoretically though, the Animation APIs should work on Uno now...

Should be good to review now though, rebased on main now that Headers merged.

Most changes are just moving and adjusting sample/test namespaces. Couple of Uno polyfills for .NET Standard 2.0. Largest functional change is making default layer for animations to be the Xaml layer over composition on Uno platforms.

@michael-hawker michael-hawker force-pushed the llama/package_collapsing branch 2 times, most recently from db4b138 to 743f7ec Compare July 11, 2023 06:59
@Arlodotexe Arlodotexe self-requested a review July 11, 2023 16:24
Make the Xaml layer the default animation layer when using Uno
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
@michael-hawker
Copy link
Member Author

Thought it was specific to #136 - however the Behaviors component won't run on UWP here, with a message about the animations assembly... needs investigation:

8> H:\code\CommunityToolkitWindows\components\Behaviors\heads\Uwp\Behaviors.Uwp.csproj : XamlCompiler error WMC1006: Cannot resolve Assembly or Windows Metadata file 'Type universe cannot resolve assembly: CommunityToolkit.WinUI.Animations, Version=8.0.0.0, Culture=neutral, PublicKeyToken=null.'

@michael-hawker
Copy link
Member Author

Arlo tested that the change wasn't introduced by this PR and the UWP head is broken on the Behaviors.Animations in main as well. Filed #137 for tracking, so we can move forward here. Therefore this PR is ready to merge once reviewed.

@michael-hawker michael-hawker enabled auto-merge (rebase) July 12, 2023 05:55
@michael-hawker michael-hawker merged commit 34e547b into main Jul 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the llama/package_collapsing branch July 13, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants