-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package clean-up for Extensions, Animations, and Behaviors #121
Conversation
Yay! Clean build for step 1! Think have Animations package working for Uno (and defaulting to XAML layer); however, we have like no samples for the Animations currently, so hard to test. Adding multi-target to Behaviors.Animations quick to see if that sample works on WASM, if so, then we have success! And then will do third step of merging the Behaviors package together. |
98dd1a4
to
5891f98
Compare
Have all the refactors/code changes done now. Everything should target Uno. Tested building for all three platforms, seems fine. Haven't been able to see the existing samples load in WASM though still, so not sure what's going on there. I don't see any Uno errors in the output. Some other Behaviors seem to work alright. Theoretically though, the Animation APIs should work on Uno now... Should be good to review now though, rebased on main now that Headers merged. Most changes are just moving and adjusting sample/test namespaces. Couple of Uno polyfills for .NET Standard 2.0. Largest functional change is making default layer for animations to be the Xaml layer over composition on Uno platforms. |
db4b138
to
743f7ec
Compare
Make the Xaml layer the default animation layer when using Uno
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something... Will have to add another sample and see after?
743f7ec
to
24985f7
Compare
Thought it was specific to #136 - however the
|
Arlo tested that the change wasn't introduced by this PR and the UWP head is broken on the Behaviors.Animations in main as well. Filed #137 for tracking, so we can move forward here. Therefore this PR is ready to merge once reviewed. |
Notice we've had a splintering of some packages and some things with very few things in them.
Going to clean-up this issue and merge things back together.
Effects
shadow stuff back intoExtensions
(originally had more plans here, but for now doesn't make sense to separate out just Shadows, even if they're the main thing not supported by Uno)Animations
target Uno - we can make the default layer on Uno the XAML layer for the XAML interop helpersBehavior.Animations
back intoBehaviors
- Not much there, and we see most folks that use Behaviors are also using the Animations package already anyway.Separate PRs:
AdvancedCollectionView
andIncrementalLoadingCollection
into aCollections
package Create Collections Package #120May effect #113
Started with 1 as draft, working on 2 next