Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenizingTextBoxItem does only check for single character TokenDelimiter #257

Open
14 tasks
minesworld opened this issue Oct 11, 2023 · 1 comment
Open
14 tasks

Comments

@minesworld
Copy link

minesworld commented Oct 11, 2023

Describe the bug

**TokenizingTextBoxItem.AutoSuggestBox.cs**

AutoSuggestBox_TextChanged()

wrong
bool lastDelimited = t[t.Length - 1] == Owner.TokenDelimiter[0];

correct
bool lastDelimited = t.EndsWith(Owner.TokenDelimiter);

Regression

No response

Reproducible in sample app?

  • This bug can be reproduced in the sample app.

Steps to reproduce

no text

Expected behavior

no text

Screenshots

No response

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Nuget packages

No response

Additional context

No response

Help us help you

No.

@ghost
Copy link

ghost commented Oct 11, 2023

Hello minesworld, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker michael-hawker transferred this issue from CommunityToolkit/WindowsCommunityToolkit Oct 16, 2023
minesworld added a commit to minesworld/CommunityToolkit-Windows that referenced this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant