-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery design improvements #88
Conversation
Hi @niels9001 Update: |
Yeah, needs some more work.. this is a nice test case to see if this is easy to replicate. I have moved the code to a new |
@niels9001 we'll want to do the setup I did for the Converters in #99 for this TitleBar package of labs. Then we'll define the property in the Labs root when we update the tooling submodule reference. In Labs it'll use the source, so that you can work on the titlebar and use it in the sample app, and in Windows it'll just grab the latest NuGet package from the feed (assuming we have the Labs feed setup there). |
@michael-hawker since the This would just be a local control for now (with a different namespace) so we shouldn't run into any issues when developing the one in Labs - once that's finished we probably need to follow what you did for the converters? |
@niels9001 yeah, should be fine as long as in different namespace. Then once the control is finished, we can swap it out and use the extensions/converters fix the same way. |
@Arlodotexe @michael-hawker the
TitleBar
code is a local copy of the code that lives in Labs: CommunityToolkit/Labs-Windows#459. I'd recommend to flag any non-blocking issues/improvements/feedback there vs. here, as that component would eventually replace this.