Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for individual component icons #66

Merged
merged 20 commits into from
Jun 21, 2023
Merged

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jun 8, 2023

This PR introduces:

  • New subcategories (e.g. Data, System)
  • Ability to set an icon in the sample markdown

Related PR: CommunityToolkit/Windows#76

@niels9001 niels9001 marked this pull request as draft June 8, 2023 10:49
@niels9001 niels9001 marked this pull request as ready for review June 8, 2023 17:31
@niels9001 niels9001 requested a review from Arlodotexe June 8, 2023 17:47
@niels9001
Copy link
Collaborator Author

@Arlodotexe Can I merge this? I'll put in the PRs to update the Windows and Windows-Labs repo's afterwards - including the new icons.

@Arlodotexe
Copy link
Member

Arlodotexe commented Jun 19, 2023

In the tooling submodule, you can always merge a PR once I've signed off. Just double check that the PRs in both repos are ready to go as well. Once we close off, any PR that updates the submodule will be broken without your changes.

@niels9001 niels9001 merged commit a852f23 into main Jun 21, 2023
@niels9001 niels9001 deleted the niels9001/iconsupport branch June 21, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants