Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MultiThreading on WASM for now #143

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

Arlodotexe
Copy link
Member

MultiThreading won't make a big difference in performance since we aren't doing a lot of thread-heavy work in our sample app. This feature has been disabled for now until it's needed again or until the SharedArrayBuffer workaround is no longer needed.

@Arlodotexe Arlodotexe self-assigned this Sep 25, 2023
@Arlodotexe Arlodotexe added sample app 🖼 Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces labels Sep 25, 2023
@michael-hawker
Copy link
Member

@Arlodotexe is there an issue tracking that for Uno or something, assume this is a .NET 8 related thing maybe?

@Arlodotexe
Copy link
Member Author

@Arlodotexe is there an issue tracking that for Uno or something, assume this is a .NET 8 related thing maybe?

No, we just don't need it for now. We enabled all wasm optimizations when upgrading to .NET 7, this was one, but it's not high-impact enough to keep turned on.

Browsers currently require certain server-side CORS flags to be enabled for SharedArrayBuffer to be usable, a remnant of the Specter/Meltdown CPU vulnerabilities from a few years ago. Our workaround requires refreshing after the ServiceWorker is registered (which it tries), but it's busted and it's not clear why.

MultiThreading won't make a big difference in performance since we aren't doing a lot of thread-heavy work in our sample app. This feature has been disabled for now until it's needed again or until the SharedArrayBuffer workaround is no longer needed.

@Arlodotexe Arlodotexe merged commit ef77ff0 into main Sep 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the wasm/disable-multithreading branch September 25, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sample app 🖼 Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants