-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Wasdk breaking on net7+ #125
Conversation
Related - CommunityToolkit/Windows#186 |
Looks like we'll have to wait for WinAppSDK to ship support for This arises from how NuGet packages pick TFMs. When the consuming Wasdk head uses This can only be fixed by waiting for the WinAppSDK to release explicit support for |
Looks like this change is targeting both I'm a bit confused based on what wasn't working for you earlier with our offline conversation... |
This was removed in the second commit. We're still using For the rest, I've updated the original post with our findings. |
Thanks @nickrandolph for working with us to find the source of the issue in the first commit so we can ship this in time. The issue in the first commit was this line. We're checking if the current I've fixed the issue in efd95db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 8.0.230828-pull-194.636
packages from CommunityToolkit/Windows#194
Worked like a charm now on Windows/WinUI3, WASM, and even Android!
Still not 100% sure if we can just add to the single class library in the Uno project vs. everything, but swapping it out from my last setup worked fine.
This PR ensures compatibility for
net7.0-windows10.0.19041.0
consumers when using the WinAppSDK head, addressing potential issues they might encounter due to TargetFramework mismatches.Background
NuGet's handling of TargetFrameworks for packages can lead to situations where, despite compatibility, the desired TFM might not be selected by the package manager.
For instance, while a project targeting
net7.0-windows10.0.19041.0
can use packages targetingnet6.0-windows10.0.19041.0
, NuGet's TFM precedence might picknet7.0
overnet6.0-windows10.0.19041.0
when the exact match isn't available.Previously, it was believed that the solution might require downgrading some Uno libraries from net7.0 to netstandard2.0. However, further investigations highlighted that this wouldn't be necessary.
Changes made in this PR:
net6.0-windows10.0.19041.0
andnet7.0-windows10.0.19041.0
.Additional info
Using this tool, you can see that:
net7.0-windows10.0.19041.0
projects can usenet6.0-windows10.0.19041.0
packagesnet7.0-windows10.0.19041.0
isnet7.0
.