Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test projects don't support csproj, dependencies or multitarget preferences #101

Open
2 of 20 tasks
michael-hawker opened this issue Jul 17, 2023 · 2 comments
Open
2 of 20 tasks
Assignees

Comments

@michael-hawker
Copy link
Member

Describe the bug

For samples we allow adding extra dependencies that are needed to showcase things just in the samples (but not required by the base component).

However, we don't have this same setup for the tests.

For instance, in DataTable it doesn't required the HeaderedControls, but we'd like to test against them still.

Steps to reproduce

N/A

Expected behavior

Able to add framework specific dependencies for UWP/WASDK to a test project within a component.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Jul 17, 2023
michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Jul 17, 2023
@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 19, 2023

We should probably just support .csproj alongside .shproj as outlined here: #62 (comment)

michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Jul 21, 2023
michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Aug 1, 2023
Arlodotexe added a commit to CommunityToolkit/Labs-Windows that referenced this issue Oct 30, 2024
@Arlodotexe Arlodotexe self-assigned this Oct 30, 2024
@Arlodotexe Arlodotexe moved this to 📋 Backlog in Toolkit 8.x Oct 30, 2024
@Arlodotexe
Copy link
Member

Arlodotexe commented Oct 30, 2024

csproj support in tests would also enable MultiTarget support, which would allow us to disable running component tests on unsupported test heads and avoid the need or workarounds like this: CommunityToolkit/Labs-Windows@b3cf490

@Arlodotexe Arlodotexe changed the title Tests can't have extra dependencies Test projects don't support csproj, dependencies or multitarget preferences Oct 30, 2024
Arlodotexe added a commit to CommunityToolkit/Labs-Windows that referenced this issue Oct 30, 2024
Arlodotexe added a commit to CommunityToolkit/Labs-Windows that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants