Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

add code of conduct and reference in readme #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

salmanmkc
Copy link

Fixes

No code of conduct was in the repo

PR Type

What kind of change does this PR introduce?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • If new feature, add to Feature List
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Apr 16, 2020

Thanks salmanmkc for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi Apr 16, 2020
Copy link
Contributor

@marb2000 marb2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Make sense for me.

@michael-hawker
Copy link
Member

@Kyaa-dost looks like we missed this one too, does this match what we're doing in our other repo? What are the .NET guidelines here should we have a local copy and a link to their online version?

@Kyaa-dost
Copy link
Contributor

@michael-hawker I think the code of conduct in this PR doesn't completely match with the updated .net foundation page. It's probably have changed since the PR was last open. So we will have to update this one and the one in WCT as well. We can do this separately or in the contribution guideline PR which has already been created in WCT. Once we update the local copy then we can link the online version in the read me as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants