-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Analyzer Benchmarks #2217
Add Analyzer Benchmarks #2217
Conversation
src/CommunityToolkit.Maui.Analyzers.UnitTests/UseCommunityToolkitInitializationAnalyzerTests.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Analyzers/UseCommunityToolkitInitializationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Analyzers/UseCommunityToolkitInitializationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Analyzers.UnitTests/UseCommunityToolkitInitializationAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Thanks @MartyIX! I added a quick + dirty Benchmark to ensure these changes improve performance + allocations. I basically just leveraged the It looks like the updates in this PR have slightly worse mean, plus an additional Gen2 allocation. Current Analyzer Benchmarks (main branch)
Updated Analyzer Benchmarks (PR #2217)
Next StepsI'll revert the changes to the Analyzers in this PR, keeping the I'll then add Thanks again for all of your help! |
Follow-up to #1477
@brminnick Sorry for being slow. You merged the PR before I could reply (sorry for being slow again ;)). I created this PR to simply show what can be done. But if you don't like the changes, don't worry, all are optional, I think you got it right.