[Shimmer] Invert dark theme colors #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@citelao Thanks for the PR, added the before vs after images |
|
Thanks @niels9001! The screenshots really help sell it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the shimmers are difficult to see in dark mode. This change makes them easier to see.
I believe this is because the colors got transposed: for light mode, the more translucent color is used for 2 & 3, whereas currently for light mode, the less translucent color is used for 2 & 3. My hunch is that this intended to account for the inversion in color b/w dark & light mode, but that's already accounted for because the colors themselves are inverted b/w those modes.
In other words, both the colors and the translucencies were transposed, when only one should have been.
Before:
After:
What changed?
How tested?
Tested using our C++ port of this code.