Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tooling to latest main #481

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Updated tooling to latest main #481

merged 5 commits into from
Aug 1, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 25, 2023

In a dedicated PR to catch potential build errors.

@Arlodotexe Arlodotexe added bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke labels Jul 25, 2023
@Arlodotexe Arlodotexe self-assigned this Jul 25, 2023
@Arlodotexe
Copy link
Member Author

Hit CommunityToolkit/Tooling-Windows-Submodule#5 and had to remove the empty AppServices sample project to move forward for now.

@Arlodotexe
Copy link
Member Author

Will need this patch as well - CommunityToolkit/Tooling-Windows-Submodule#113

@Arlodotexe
Copy link
Member Author

Investigation into CI errors is continuing here - CommunityToolkit/Windows#157

@michael-hawker
Copy link
Member

michael-hawker commented Aug 1, 2023

@Arlodotexe updated this PR/branch based on CommunityToolkit/Tooling-Windows-Submodule#116 and made the other required changes.

We'll see if this works now, big test... 🤞

This does mean with the automated versioning each PR will update all the packages, will need to look at the https://github.com/marketplace/actions/changed-files tool to look at only pushing packages with changes later...

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, hopefully we're all in-sync now.

Appears the root of the issue was the change made to the FrameworkElment AncestorType method signature based on a proposed bug fix. As it should only attach to FrameworkElement and not DependencyProperty.

However, this caused a signature mismatch and nuget resolution was pulling the prior packages still until we've re-aligned here. Hopefully, we won't hit this in the future again... but at least have some better ideas about what happened and how it can manifest, though it wasn't the easiest to catch at first, the output from the CI when the test app crashes is fairly non-existent. I had a lot of issues getting logging to work, and upgrading to the latest test code is blocked on WASDK, see microsoft/testfx#1726. So future improvements are needed later.

@michael-hawker michael-hawker merged commit ae49c93 into main Aug 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the update/tooling branch August 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants