Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SettingsControls] Bugfixes and improvements #373

Merged
merged 9 commits into from
Feb 26, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Feb 24, 2023

This PR introduces the following changes:

1. Fix for focus visual bug for RightAlignedToggleSwitch
Before:
image

After:
image


2. Changing UniformGridLayout to StackLayout
This resolves issues where the content is not always rendered correctly. We were using UniformGridLayout to resolve the expanding bug, but in the end that wasn't working either. StackLayout would be the preferred way to do this anyways.


3. Updating the SettingsExpander content MinHeight
By default, the Expander.Content MinHeight is enherited from the Header. This resulted, in some cases, that a gap was visible when a SettingsCard would have a lower MinHeight. It's now set to 16 and is overrideable.(SettingsExpanderContentMinHeight)


4. Fixing a visual glitch whenever Content is null
If the content is null, the contentPresenter was still visible. There's a 8px TopMargin used to show a gap.. but that doesn't make sense when Content is null.

Before:
SettingsCardJumpBefore

After:
SettingsCardJumpAfter

5. Other fixes

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion, looks good otherwise.

@michael-hawker
Copy link
Member

Couple of small comments/questions, otherwise should be good. After get those answers, can either make changes or merge as needed.

@niels9001 niels9001 merged commit 6542f93 into main Feb 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/settingscontrolsfixes branch February 26, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants