-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New experiment improvements #131
Conversation
Duplicated change with #126
This list is based on what's most commonly used in existing toolkit tests.
it doesn't work there
Co-authored-by: Arlo <[email protected]>
Co-authored-by: Arlo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, if we use ProjectTemplate
it should auto-relpace on creation, right? That'll make the guidance directly applicable to the locations in the solution which could be handy?
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
This reverts commit 5dccf8a.
to reference the code being developed & to use a naming convention better matched to the wider toolkit convention
…d code This is to reduce the effort required to begin work on an experiment.
I'm inclined to add references to This goal of doing this is to make it easier for anyone creating an experiment to be able to write tests without having to "faff" with adding multiple packages (in different projects) when this is a common task we can do for them. |
Also now need to update https://github.com/CommunityToolkit/Labs-Windows/tree/i127-NewExperimentImprovements/template in light of #136 |
Sorry, missed this comment. Yes, we should do this for the template as well I guess. I think we had discussed adding some common references so that folks can just remove them. That can be done with #132, which now has a PR open here: #139. |
Fixes #127
This improves the template for creating a new experiment so that it is more useful and removes possible issues.