Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Provider] Don‘t add local provider when use WebAccountProviderType.Any #200

Merged

Conversation

Richasy
Copy link
Contributor

@Richasy Richasy commented Oct 20, 2022

Fixes #199

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Adding a local provider will bring a misleading account login option.

image

What is the new behavior?

Don't add a local provider to avoid this behavior.

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Oct 20, 2022

Thanks Richasy for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Richasy Richasy changed the title [Windows Provider] Don‘t add local provider when getting WebAccountProvider [Windows Provider] Don‘t add local provider when use WebAccountProviderType.Any Oct 20, 2022
@michael-hawker michael-hawker added this to the 7.1.3 milestone Oct 20, 2022
@michael-hawker michael-hawker force-pushed the richasy/removeLocalProvider branch from e3ec46f to b95c963 Compare December 15, 2022 18:27
@michael-hawker
Copy link
Member

Tested out the repro steps before and after this change and confirm the extra option goes away, thanks!

@michael-hawker michael-hawker force-pushed the richasy/removeLocalProvider branch from b95c963 to e48aece Compare December 15, 2022 19:05
@michael-hawker michael-hawker merged commit d413fa8 into CommunityToolkit:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowsProvider displays two “Work or school account" options when using WebAccountProviderType.Any
2 participants