-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental attribute for GraphPresenter and sample updates #148
Conversation
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@michael-hawker added you in case you are curious. This was based on your sample in #55. It works great! Pretty easy to drop in and make a few adjustments 😊 |
</Grid.ColumnDefinitions> | ||
<controls:ImageEx | ||
Grid.RowSpan="2" | ||
DataContext="{x:Bind RemoteItem, Converter={StaticResource OneDriveThumbnailConverter}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose since we're just doing a sample and using x:Bind here already it'd be easier to just use a function call vs. a converter, eh? (Would probably remove half the lines in the code-behind for us... 😋
I think I originally used a converter as I intended that converter may end-up in the Toolkit or a control template in the long run, but that's something we can re-adapt later if needed vs. having a simpler to use function in the code behind for a sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 😅 I didn't even think about that. I'll make them methods for simplicity/consistency.
Yeah, I'll pull things down tomorrow and give it a spin. Excited to check out all the sample updates. 🎉 |
Edit: Cleaned and rebuilt seemed to work. |
Try testing out some of the other samples, got a scope exception and seeing some index exceptions eaten internally somewhere. But otherwise looking great! 🎉 |
@michael-hawker weird exception, I haven't seen that myself. I'll see if I can play around and get it to repro. I'll also get those tests updated 👍 |
I'm not sure about the exception, so I've logged bug #149 I have a hunch that the issue is in TokeninzingTextBox and not in the PeoplePicker itself. |
Fixes #55
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We are getting close to release, and the
GraphPresenter
is not quite completed. There are a few additional features to add and scenarios to test before it will be ready for regular use.Also, the sample app has several GraphPresenter samples, but they are all sharing the same file. This makes it a bit harder to read the code.
What is the new behavior?
I've added the Experimental attribute to the
GraphPresenter
and associatedQueryOption
classes. This warns developers who choose to consume them.Next, I've taken the existing
GraphPresenter
sub-samples and moved them into individual pages in their own folder. This cleans up the sample a bit and makes it easier to see each sample in isolation and understand how it works.Lastly, I've added an additional
GraphPresenter
sub-sample for OneDrive as detailed in #55.PR Checklist
Please check if your PR fulfills the following requirements:
Other information