Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support display account management panel #110

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Support display account management panel #110

merged 3 commits into from
Jun 4, 2021

Conversation

Richasy
Copy link
Contributor

@Richasy Richasy commented Jun 4, 2021

PR Type

What kind of change does this PR introduce?

Feature

Support display account management panel:

image

What is the current behavior?

At this stage, WindowsProvider provides login and logout functions, the logout process does not require user involvement.

What is the new behavior?

Some usage scenarios may need to display the currently logged-in user and provide some custom operations.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Breaking changes

The login panel and the management panel are two different usage scenarios, and their HeaderText may not be mixed, so I made some modifications:

  1. Modify the original HeaderText to AddAccountHeaderText.
  2. Add a new property ManageAccountHeaderText is used to display in the account management panel.
  3. The constructor parameters of AccountsSettingsPaneConfig have been adjusted.

Other information

A new object has been added: WebAccountCommandParameter. It is not used as an IList property in the definition of AccountsSettingsPaneConfig, because currently WindowsProvider only supports single account.

@ghost
Copy link

ghost commented Jun 4, 2021

Thanks Richasy for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost Jun 4, 2021
Copy link
Member

@shweaver-MSFT shweaver-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Works really well and is simple to configure. Great work!

@shweaver-MSFT shweaver-MSFT merged commit 742d953 into CommunityToolkit:main Jun 4, 2021
shweaver-MSFT pushed a commit that referenced this pull request Jun 4, 2021
* Support display account management panel

Co-authored-by: Anran Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants