-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Python and MATLAB code #15
Conversation
3b92274
to
f3e6bd1
Compare
Would love to see this merged down. Thanks for the effort, @Calman102 💯 |
Would be great to see this merged! Any idea on when we could see this? |
@bryansray @bobzomer were you able to pull this change down and see it working? If so, can you let us know. Thanks! |
Yes. I've tested the proposed change and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating file headers to match repo licensing now (see #20). Contributor has already signed .NET Foundation CLA, so should be no legal impact here. This is just a text change to align everything to the current proper state.
No legal ramifications here as CLA signed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully build should be good now and we can get this merged.
Hmm, looks like something may have happened to our build since it last ran...
@Arlodotexe mind investigating off of main? We should be able to track the latest build here actually (and we knew it originally built as well): https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=79469&view=results Edit: Yeah, same issue there... 🙁 I'll merge this since it built before and open a new issue to work towards a fix. |
Fixes #14