Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python and MATLAB code #15

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

Calman102
Copy link
Contributor

@Calman102 Calman102 commented Dec 10, 2020

Fixes #14

@net-foundation-cla
Copy link

net-foundation-cla bot commented Dec 10, 2020

CLA assistant check
All CLA requirements met.

@bryansray
Copy link

Would love to see this merged down. Thanks for the effort, @Calman102 💯

@bobzomer
Copy link

Would be great to see this merged! Any idea on when we could see this?

@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 24, 2022
@michael-hawker
Copy link
Member

@bryansray @bobzomer were you able to pull this change down and see it working? If so, can you let us know. Thanks!

@bobzomer
Copy link

@bryansray @bobzomer were you able to pull this change down and see it working? If so, can you let us know. Thanks!

Yes. I've tested the proposed change and it works.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating file headers to match repo licensing now (see #20). Contributor has already signed .NET Foundation CLA, so should be no legal impact here. This is just a text change to align everything to the current proper state.

ColorCode.Core/Compilation/Languages/MatLab.cs Outdated Show resolved Hide resolved
ColorCode.Core/Compilation/Languages/Python.cs Outdated Show resolved Hide resolved
No legal ramifications here as CLA signed.
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully build should be good now and we can get this merged.

@michael-hawker
Copy link
Member

michael-hawker commented Sep 30, 2022

Hmm, looks like something may have happened to our build since it last ran...

C:\hostedtoolcache\windows\dotnet\sdk\6.0.400\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(358,5): error NETSDK1127: The targeting pack Microsoft.NETCore.App is not installed. Please restore and try again. [D:\a\1\s\ColorCode.WinUI\ColorCode.WinUI.csproj]

@Arlodotexe mind investigating off of main?

We should be able to track the latest build here actually (and we knew it originally built as well): https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=79469&view=results

Edit: Yeah, same issue there... 🙁 I'll merge this since it built before and open a new issue to work towards a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python, MATLAB, Julia and other scientific / mathematical languages
5 participants